feat(transformer): add ast changed hint in InjectGlobalVariables#7205
feat(transformer): add ast changed hint in InjectGlobalVariables#7205IWANABETHATGUY wants to merge 2 commits intomainfrom
InjectGlobalVariables#7205Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #7205 will not alter performanceComparing Summary
|
Boshen
changed the title
oxc_transformer InjectGlobalVariables
|
For every test, I add an extra assert to make sure if the ast changed, the |
IWANABETHATGUY
force-pushed
the
feat/changed-hint-in-oxc-transform-plugin
branch
from
1e9ba48 to
b2ab578
Compare
|
Seems noise, same as #7203 (comment) |
|
It seems the plugin is not very complex, I suggest syncing the semantic rather than adding a state to indicate it's no change. |
|
3 participants
here is a usage, https://github.com/rolldown/rolldown/blob/01197ec5548a091f8f1c1b6f112c1d30e883b0d9/crates/rolldown/src/utils/pre_process_ecma_ast.rs#L100-L106,
this hint could avoid recreating semantic info, if the ast is not changed.